Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b17d7be2 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

debuggerd: recognize jumps to non-executable memory. 

We have fairly fancy detection of stack pointer issues, but nothing for the program counter...

Bug: https://issuetracker.google.com/365602121
Change-Id: I7e7061a1b473089a0f31438df5ebc65b283475bc
parent 1024225b

debuggerd/libdebuggerd/tombstone_proto.cpp

+3 −0
Original line number Diff line number Diff line
@@ -356,6 +356,9 @@ static void dump_probable_cause(Tombstone* tombstone, unwindstack::AndroidUnwind 
    auto map_info = maps->Find(fault_addr);

    if (map_info != nullptr && map_info->flags() == PROT_EXEC) {

      cause = "execute-only (no-read) memory access error; likely due to data in .text.";

    } else if (fault_addr == target_thread.registers->pc() &&

               map_info != nullptr && (map_info->flags() & PROT_EXEC) == 0) {

      cause = "trying to execute non-executable memory.";

    } else {

      cause = get_stack_overflow_cause(fault_addr, target_thread.registers->sp(), maps);

    }