Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae4ce8cc authored by T.J. Mercier's avatar T.J. Mercier
Browse files

libprocessgroup: Remove cgroup.rc file 

The cgroup.rc file was introduced in 192aee78 ("libprocessgroup: Add
support for task profiles") back with the initial support for task
profiles. It was intended to optimize performance associated with cgroup
operations. However over time, supporting this file led to making
libprocessgroup code more complicated (such as the cgrouprc LLNDK
interface), and the file ended up getting mmaped into nearly every
process on Android even though only a handful of them actually use it.
Replacing this file with reading and parsing of cgroup information on
demand allows us to simplify and shrink libprocessgroup, and eliminates
thousands of unused mappings without negatively affecting boot time or
other performance metrics.

Bug: 349105928
Test: Verified with memcg v2 and MaxActivationDepth 1 on Cuttlefish, Raven, and Mokey
Change-Id: Ic3f01fdf7fda89a56ab80657e1cf4573156273e6
parent 8dd9d455

fs_mgr/libsnapshot/snapuserd/Android.bp

+3 −4
Original line number Diff line number Diff line
@@ -85,9 +85,9 @@ cc_library_static { 
        "libsnapshot_cow",

        "liburing",

        "libprocessgroup",

        "libprocessgroup_util",

        "libjsoncpp",

        "libcgrouprc",

        "libcgrouprc_format",

    ],

    include_dirs: ["bionic/libc/kernel"],

    export_include_dirs: ["include"],
@@ -129,9 +129,9 @@ cc_defaults { 
        "libsnapshot_cow",

        "libsnapuserd",

        "libprocessgroup",

        "libprocessgroup_util",

        "libjsoncpp",

        "libcgrouprc",

        "libcgrouprc_format",

        "libsnapuserd_client",

        "libz",

        "liblz4",
@@ -221,9 +221,9 @@ cc_defaults { 
        "libsnapshot_cow",

        "libsnapuserd",

        "libprocessgroup",

        "libprocessgroup_util",

        "libjsoncpp",

        "libcgrouprc",

        "libcgrouprc_format",

        "liburing",

        "libz",

    ],
@@ -319,7 +319,6 @@ cc_binary_host { 
        "libprocessgroup",

        "libjsoncpp",

        "libcgrouprc",

        "libcgrouprc_format",

        "liburing",

        "libz",

    ],

init/Android.bp

+0 −1
Original line number Diff line number Diff line
@@ -163,7 +163,6 @@ libinit_cc_defaults { 
        "libavb",

        "libavf_cc_flags",

        "libbootloader_message",

        "libcgrouprc_format",

        "liblmkd_utils",

        "liblz4",

        "libzstd",

init/init.cpp

+0 −3
Original line number Diff line number Diff line
@@ -636,9 +636,6 @@ static Result<void> SetupCgroupsAction(const BuiltinArguments&) { 
        LOG(INFO) << "Cgroups support in kernel is not enabled";

        return {};

    }

    // Have to create <CGROUPS_RC_DIR> using make_dir function

    // for appropriate sepolicy to be set for it

    make_dir(android::base::Dirname(CGROUPS_RC_PATH), 0711);

    if (!CgroupSetup()) {

        return ErrnoError() << "Failed to setup cgroups";

    }

libcutils/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -301,7 +301,7 @@ cc_defaults { 
        android: {

            static_executable: true,

            static_libs: [

                "libcgrouprc_format",

                "libprocessgroup_util",

            ] + test_libraries + always_static_test_libraries,

        },

        not_windows: {

libprocessgroup/Android.bp

+2 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ soong_config_module_type { 


libprocessgroup_flag_aware_cc_defaults {

    name: "libprocessgroup_build_flags_cc",

    cpp_std: "gnu++20",

    cpp_std: "gnu++23",

    soong_config_variables: {

        memcg_v2_force_enabled: {

            cflags: [
@@ -116,5 +116,6 @@ cc_test { 
    ],

    static_libs: [

        "libgmock",

        "libprocessgroup_util",

    ],

}