Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abd6773b authored by Elliott Hughes's avatar Elliott Hughes
Browse files

Remove the emulator special case from the "adb root" code. 

The emulator is essential an "eng" build, so the regular properties
should suffice.

Change-Id: Id63b3918f9b0b04b0d887ed886535b9976a9cc85
parent db3a5d98

adb/adb_main.c

+0 −7
Original line number Diff line number Diff line
@@ -108,13 +108,6 @@ static bool should_drop_privileges() { 
#if defined(ALLOW_ADBD_ROOT)

    char value[PROPERTY_VALUE_MAX];



    // The emulator is never secure, so don't drop privileges there.

    // TODO: this seems like a bug --- shouldn't the emulator behave like a device?

    property_get("ro.kernel.qemu", value, "");

    if (strcmp(value, "1") == 0) {

        return false;

    }



    // The properties that affect `adb root` and `adb unroot` are ro.secure and

    // ro.debuggable. In this context the names don't make the expected behavior

    // particularly obvious.