Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab079af2 authored by Bowgo Tsai's avatar Bowgo Tsai
Browse files

Revert "Re-land removing RECOVERY_AS_BOOT check for init_first_stage" 

This reverts commit 4818f748.

The previous commit might introduce a build break on legacy
devices that with a smaller /boot partition size, because it
outputs the first-stage init and the second-stage init binaries
in the following locations, respectively (when
BOARD_USES_RECOVERY_AS_BOOT is true).

    * $OUT/recovery/root/first_stage_ramdisk/init
    * $OUT/recovery/root/system/bin/init

The first one is not needed because there is already a symlink
under $OUT/recovery/root:  init -> /system/bin/init.

Bug: 193565271
Test: `lunch aosp_flame-userdebug`, `make bootimage_debug` then
      checks the output under $OUT/debug_ramdisk/.
Test: Performs the same check for `lunch aosp_bramble-userdebug`.
Change-Id: I6277a6c4c0980bd976cc35db6ca99eafc6bf3f5a
parent e3ec5f93

init/Android.bp

+4 −1
Original line number Diff line number Diff line
@@ -257,7 +257,7 @@ soong_config_module_type { 
    name: "init_first_stage_cc_defaults",

    module_type: "cc_defaults",

    config_namespace: "ANDROID",

    bool_variables: ["BOARD_BUILD_SYSTEM_ROOT_IMAGE"],

    bool_variables: ["BOARD_BUILD_SYSTEM_ROOT_IMAGE", "BOARD_USES_RECOVERY_AS_BOOT"],

    properties: ["installable"],

}
@@ -269,6 +269,9 @@ init_first_stage_cc_defaults { 
        BOARD_BUILD_SYSTEM_ROOT_IMAGE: {

            installable: false,

        },

        BOARD_USES_RECOVERY_AS_BOOT: {

            installable: false,

        },

    },

}

init/Android.mk

+2 −0
Original line number Diff line number Diff line
@@ -9,8 +9,10 @@ LOCAL_LICENSE_KINDS := SPDX-license-identifier-Apache-2.0 
LOCAL_LICENSE_CONDITIONS := notice

LOCAL_NOTICE_FILE := $(LOCAL_PATH)/NOTICE

ifneq ($(BOARD_BUILD_SYSTEM_ROOT_IMAGE),true)

ifneq ($(BOARD_USES_RECOVERY_AS_BOOT),true)

LOCAL_REQUIRED_MODULES := \

   init_first_stage \



endif  # BOARD_USES_RECOVERY_AS_BOOT

endif  # BOARD_BUILD_SYSTEM_ROOT_IMAGE

include $(BUILD_PHONY_PACKAGE)