Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a287592b authored by Yi Kong's avatar Yi Kong
Browse files

Remove unnecessary std::move 

Moving a temporary object prevents copy elision, and could reduce
performance.

This fixes -Wpessimizing-move compiler warning.

Test: presubmit
Bug: 154270751
Change-Id: I6d967966f75fb15e9b5c5e4661bd5ca3af37e8e0
parent 206bdf2f

fastboot/vendor_boot_img_utils_test.cpp

+1 −1
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ struct TestFileHandle { 
  protected:

    // |rel_path| is the relative path under test data directory.

    TestFileHandle(const std::filesystem::path& rel_path)

        : abs_path_(std::move(std::filesystem::path(GetExecutableDirectory()) / rel_path)) {}

        : abs_path_(std::filesystem::path(GetExecutableDirectory()) / rel_path) {}

    // Given |read_fd|, the readonly fd on the test file, return an fd that's suitable for client

    // to use. Implementation is responsible for managing the lifetime of the returned fd.

    virtual android::base::Result<borrowed_fd> Transform(const std::filesystem::path& abs_path,