Commit a1080167 authored Sep 04, 2015 by Yabin Cui

adb: move adb to poll.

It is reported that the registered fd can be bigger than FD_SETSIZE, and can't be
handled by select(). By moving to poll(), we can remove the limitation.
Although we can't ignore the possibility that there is a fd leak, but we can
still make the potential bug more explicit by moving to poll().
We didn't move to epoll() because it is not supported on mac.

Bug: 23820751

Change-Id: Icb39329c4984f1fef749472c9e088682ee8c3444

parent 33046dcb

adb/adb.cpp

+1 −0

Original line number	Diff line number	Diff line
		@@ -177,6 +177,7 @@ static void setup_trace_mask() {
		{"jdwp", TRACE_JDWP},
		{"services", TRACE_SERVICES},
		{"auth", TRACE_AUTH},
		{"fdevent", TRACE_FDEVENT},
		{"shell", TRACE_SHELL}};

		std::vector<std::string> elements = android::base::Split(trace_setting, " ");

adb/fdevent.cpp

+202 −563

File changed.

Preview size limit exceeded, changes collapsed.

adb/fdevent_test.cpp

+48 −2

File changed.

Preview size limit exceeded, changes collapsed.