Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a031a91b authored by Kenny Root's avatar Kenny Root
Browse files

Skip argument when parsing adb install 

A command line flag with an argument was checked in the Pm.java code,
but it wasn't being checked by "adb install" so attempts to use it
failed.

Change-Id: I0b84a4203a416f7323fa823c0f1f1750670d0c76
parent 8898c874

adb/commandline.c

+5 −2
Original line number Diff line number Diff line
@@ -1419,16 +1419,19 @@ int install_app(transport_type transport, char* serial, int argc, char** argv) 
        if (*argv[i] != '-') {

            file_arg = i;

            break;

        } else if (!strcmp(argv[i], "-i")) {

            // Skip the installer package name.

            i++;

        } else if (!strcmp(argv[i], "-s")) {

            where = SD_DEST;

        }

    }



    if (file_arg < 0) {

        fprintf(stderr, "can't find filename in arguments");

        fprintf(stderr, "can't find filename in arguments\n");

        return 1;

    } else if (file_arg + 2 < argc) {

        fprintf(stderr, "too many files specified; only takes APK file and verifier file");

        fprintf(stderr, "too many files specified; only takes APK file and verifier file\n");

        return 1;

    }