Merge "Flattenable: switch from assignment to memcpy()." am: b2356a6993 (9f106bec) · Commits · e / os / android_system_core

include/utils/Flattenable.h

+9 −2

Original line number	Original line	Diff line number	Diff line
	@@ -19,10 +19,13 @@


	#include <stdint.h>		#include <stdint.h>
			#include <string.h>
	#include <sys/types.h>		#include <sys/types.h>
	#include <utils/Errors.h>		#include <utils/Errors.h>
	#include <utils/Debug.h>		#include <utils/Debug.h>

			#include <type_traits>

	namespace android {		namespace android {


	@@ -60,14 +63,18 @@ public:
	// write a POD structure		// write a POD structure
	template<typename T>		template<typename T>
	static void write(void*& buffer, size_t& size, const T& value) {		static void write(void*& buffer, size_t& size, const T& value) {
	static_cast<T>(buffer) = value;		static_assert(std::is_trivially_copyable<T>::value,
			"Cannot flatten a non-trivially-copyable type");
			memcpy(buffer, &value, sizeof(T));
	advance(buffer, size, sizeof(T));		advance(buffer, size, sizeof(T));
	}		}

	// read a POD structure		// read a POD structure
	template<typename T>		template<typename T>
	static void read(void const*& buffer, size_t& size, T& value) {		static void read(void const*& buffer, size_t& size, T& value) {
	value = static_cast<T const>(buffer);		static_assert(std::is_trivially_copyable<T>::value,
			"Cannot unflatten a non-trivially-copyable type");
			memcpy(&value, buffer, sizeof(T));
	advance(buffer, size, sizeof(T));		advance(buffer, size, sizeof(T));
	}		}
	};		};