Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9eb55186 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

adbd's children should have SIGPIPE set to SIG_DFL. 

POSIX lets you choose whether or not SIGPIPE disposition is inherited,
and Linux chose "yes". Work around that.

Bug: http://b/35209888
Test: "ps -A | head" without the toybox workaround
Change-Id: I6b5afa3d87eb2af04b24c6c37fa338ab60ad2336
parent 892b158a

adb/shell_service.cpp

+4 −0
Original line number Diff line number Diff line
@@ -320,6 +320,10 @@ bool Subprocess::ForkAndExec(std::string* error) { 
        parent_error_sfd.reset(-1);

        close_on_exec(child_error_sfd);



        // adbd sets SIGPIPE to SIG_IGN to get EPIPE instead, and Linux propagates that to child

        // processes, so we need to manually reset back to SIG_DFL here (http://b/35209888).

        signal(SIGPIPE, SIG_DFL);



        if (command_.empty()) {

            execle(_PATH_BSHELL, _PATH_BSHELL, "-", nullptr, cenv.data());

        } else {