Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9434f59c authored by Elliott Hughes's avatar Elliott Hughes
Browse files

Remove String8::toUpper(). 

Actually, it looks like it's only toLower() that's used, so let's remove
toUpper() separately, since it's so easy.

Test: treehugger
Change-Id: I8fae9fa513b2a34d5bd6b3f64e9305a1ee3c1ec4
parent 561209ee

libutils/String8.cpp

+0 −13
Original line number Diff line number Diff line
@@ -426,19 +426,6 @@ void String8::toLower() 
    unlockBuffer(length);

}



void String8::toUpper()

{

    const size_t length = size();

    if (length == 0) return;



    char* buf = lockBuffer(length);

    for (size_t i = length; i > 0; --i) {

        *buf = static_cast<char>(toupper(*buf));

        buf++;

    }

    unlockBuffer(length);

}



// ---------------------------------------------------------------------------

// Path functions

libutils/String8_fuzz.cpp

+0 −3
Original line number Diff line number Diff line
@@ -41,9 +41,6 @@ std::vector<std::function<void(FuzzedDataProvider*, android::String8*, android:: 
                },



                // Casing

                [](FuzzedDataProvider*, android::String8* str1, android::String8*) -> void {

                    str1->toUpper();

                },

                [](FuzzedDataProvider*, android::String8* str1, android::String8*) -> void {

                    str1->toLower();

                },

libutils/include/utils/String8.h

+0 −1
Original line number Diff line number Diff line
@@ -130,7 +130,6 @@ public: 
            bool                removeAll(const char* other);



            void                toLower();

            void                toUpper();





    /*