Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9367f4f9 authored by John Grossman's avatar John Grossman
Browse files

Replace a segfault with a warning. 

Just print a warning if ADB_EXTERNAL_STORAGE is not defined when ADB
runs instead of segfaulting.  If we really don't want to continue to
run, we can make this a fatal error instead.

Change-Id: Icfc5fb9e594b0a310029f1dca7e9476f27ceb7bc
parent a8c2112b

adb/adb.c

+7 −1
Original line number Diff line number Diff line
@@ -1024,7 +1024,13 @@ int adb_main(int is_daemon, int server_port) 


    // Our external storage path may be different than apps, since

    // we aren't able to bind mount after dropping root.

    setenv("EXTERNAL_STORAGE", getenv("ADB_EXTERNAL_STORAGE"), 1);

    const char* adb_external_storage = getenv("ADB_EXTERNAL_STORAGE");

    if (NULL != adb_external_storage) {

        setenv("EXTERNAL_STORAGE", adb_external_storage, 1);

    } else {

        D("Warning: ADB_EXTERNAL_STORAGE is not set.  Leaving EXTERNAL_STORAGE"

          " unchanged.\n");

    }



    /* don't listen on a port (default 5037) if running in secure mode */

    /* don't run as root if we are running in secure mode */