Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e71ddea authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

libcutils: bug str_parms.c:str_parms_get_float(). 

str_parms_get_float did not return the output into
*val. Only output if returning with no error. Audit
shows no internal users of this library function

Change-Id: I14a3f08a098072a159dd93f85ead36b3f445816f
parent ba02cd1e

libcutils/str_parms.c

+5 −4
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2011 The Android Open Source Project

 * Copyright (C) 2011-2013 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.
@@ -280,10 +280,11 @@ int str_parms_get_float(struct str_parms *str_parms, const char *key, 
        return -ENOENT;



    out = strtof(value, &end);

    if (*value != '\0' && *end == '\0')

        return 0;



    if (*value == '\0' || *end != '\0')

        return -EINVAL;



    *val = out;

    return 0;

}



static bool combine_strings(void *key, void *value, void *context)