Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a7e7039 authored by Josh Gao's avatar Josh Gao
Browse files

crash_dump: make output fd O_APPEND. 

Bug: http://b/35209835
Test: mma
Change-Id: I447e3cfa3361f9c8b4b3335d0abccd1fe4c98e0f
parent af776fd5

debuggerd/crash_dump.cpp

+8 −0
Original line number Diff line number Diff line
@@ -155,6 +155,14 @@ static bool tombstoned_connect(pid_t pid, unique_fd* tombstoned_socket, unique_f 
    return false;

  }



  // Make the fd O_APPEND so that our output is guaranteed to be at the end of a file.

  // (This also makes selinux rules consistent, because selinux distinguishes between writing to

  // a regular fd, and writing to an fd with O_APPEND).

  int flags = fcntl(tmp_output_fd.get(), F_GETFL);

  if (fcntl(tmp_output_fd.get(), F_SETFL, flags | O_APPEND) != 0) {

    PLOG(WARNING) << "failed to set output fd flags";

  }



  *tombstoned_socket = std::move(sockfd);

  *output_fd = std::move(tmp_output_fd);

  return true;