Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 880d5664 authored by Tom Cherry's avatar Tom Cherry
Browse files

init: add TODO for mount operations. 

mount operations should be done in vendor init context, but their
complexity currently limits this.  Add a TODO to make this reason
clear to those viewing the code.

Bug: 72488820
Test: N/A
Change-Id: I8b6dd92aa79f31dc24603559ed6de0815facfcba
parent 01ba1157

init/builtins.cpp

+4 −0
Original line number Diff line number Diff line
@@ -1030,6 +1030,10 @@ const BuiltinFunctionMap::Map& BuiltinFunctionMap::map() const { 
        {"load_system_props",       {0,     0,    {false,  do_load_system_props}}},

        {"loglevel",                {1,     1,    {false,  do_loglevel}}},

        {"mkdir",                   {1,     4,    {true,   do_mkdir}}},

        // TODO: Do mount operations in vendor_init.

        // mount_all is currently too complex to run in vendor_init as it queues action triggers,

        // imports rc scripts, etc.  It should be simplified and run in vendor_init context.

        // mount and umount are run in the same context as mount_all for symmetry.

        {"mount_all",               {1,     kMax, {false,  do_mount_all}}},

        {"mount",                   {3,     kMax, {false,  do_mount}}},

        {"umount",                  {1,     1,    {false,  do_umount}}},