Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 869ce5d4 authored by Nick Kralevich's avatar Nick Kralevich Committed by android-build-merger
Browse files

Merge "init/service.cpp: fix FD leak for services with consoles"

am: 4173d9b5

Change-Id: Iaf8e2857ccb425cc7a41f286f5353c76333cba9d
parents 1e62d3e0 4173d9b5
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -567,9 +567,9 @@ bool Service::Start() {
            console_ = default_console;
        }

        bool have_console = (open(console_.c_str(), O_RDWR | O_CLOEXEC) != -1);
        bool have_console = (access(console_.c_str(), R_OK | W_OK) != -1);
        if (!have_console) {
            PLOG(ERROR) << "service '" << name_ << "' couldn't open console '" << console_ << "'";
            PLOG(ERROR) << "service '" << name_ << "' cannot gain read/write access to console '" << console_ << "'";
            flags_ |= SVC_DISABLED;
            return false;
        }