Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84b998f4 authored by George Burgess IV's avatar George Burgess IV Committed by android-build-merger
Browse files

Merge "Silence a use-after-free warning from the analyzer" am: 8c853c43

am: 584853bd

Change-Id: I355b80ad7e59daeba569e6f9bb8eea853121acf9
parents 0fdb8616 584853bd
Loading
Loading
Loading
Loading
+5 −0
Original line number Diff line number Diff line
@@ -442,6 +442,11 @@ void RefBase::decStrong(const void* id) const
    // and all accesses to refs happen before its deletion in the final decWeak.
    // The destructor can safely access mRefs because either it's deleting
    // mRefs itself, or it's running entirely before the final mWeak decrement.
    //
    // Since we're doing atomic loads of `flags`, the static analyzer assumes
    // they can change between `delete this;` and `refs->decWeak(id);`. This is
    // not the case. The analyzer may become more okay with this patten when
    // https://bugs.llvm.org/show_bug.cgi?id=34365 gets resolved. NOLINTNEXTLINE
    refs->decWeak(id);
}