Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e771de3 authored by George Burgess IV's avatar George Burgess IV
Browse files

logging: always enable DCHECK for the static analyzer 

This helps us have less false-positives.

We do this instead of `#undef NDEBUG`, since undefing NDEBUG actually
gave us more false-positives (...and build breakages) than simply
leaving it defined.

Bug: None
Test: Ran the static analyzer across internal master. 213 fewer warnings
(15 Medium, 2 Low, the remainder are 'Analyzer'). All of the dropped
warnings I audited were false-positives. It adds ~3 Tidy warnings.
Change-Id: Ibedab60ca7e9d2b0772896222b83d2e7ab064afe
parent 0f185bb1

base/include/android-base/logging.h

+2 −2
Original line number Diff line number Diff line
@@ -315,7 +315,7 @@ struct LogAbortAfterFullExpr { 
// DCHECKs are debug variants of CHECKs only enabled in debug builds. Generally

// CHECK should be used unless profiling identifies a CHECK as being in

// performance critical code.

#if defined(NDEBUG)

#if defined(NDEBUG) && !defined(__clang_analyzer__)

static constexpr bool kEnableDChecks = false;

#else

static constexpr bool kEnableDChecks = true;
@@ -339,7 +339,7 @@ static constexpr bool kEnableDChecks = true; 
  if (::android::base::kEnableDChecks) CHECK_STREQ(s1, s2)

#define DCHECK_STRNE(s1, s2) \

  if (::android::base::kEnableDChecks) CHECK_STRNE(s1, s2)

#if defined(NDEBUG)

#if defined(NDEBUG) && !defined(__clang_analyzer__)

#define DCHECK_CONSTEXPR(x, out, dummy)

#else

#define DCHECK_CONSTEXPR(x, out, dummy) CHECK_CONSTEXPR(x, out, dummy)