Loading logd/LogListener.cpp +3 −1 Original line number Diff line number Diff line Loading @@ -45,7 +45,6 @@ bool LogListener::onDataAvailable(SocketClient *cli) { char buffer[sizeof_log_id_t + sizeof(uint16_t) + sizeof(log_time) + LOGGER_ENTRY_MAX_PAYLOAD]; struct iovec iov = { buffer, sizeof(buffer) }; memset(buffer, 0, sizeof(buffer)); char control[CMSG_SPACE(sizeof(struct ucred))]; struct msghdr hdr = { Loading @@ -60,6 +59,9 @@ bool LogListener::onDataAvailable(SocketClient *cli) { int socket = cli->getSocket(); // To clear the entire buffer is secure/safe, but this contributes to 1.68% // overhead under logging load. We are safe because we check counts. // memset(buffer, 0, sizeof(buffer)); ssize_t n = recvmsg(socket, &hdr, 0); if (n <= (ssize_t)(sizeof(android_log_header_t))) { return false; Loading Loading
logd/LogListener.cpp +3 −1 Original line number Diff line number Diff line Loading @@ -45,7 +45,6 @@ bool LogListener::onDataAvailable(SocketClient *cli) { char buffer[sizeof_log_id_t + sizeof(uint16_t) + sizeof(log_time) + LOGGER_ENTRY_MAX_PAYLOAD]; struct iovec iov = { buffer, sizeof(buffer) }; memset(buffer, 0, sizeof(buffer)); char control[CMSG_SPACE(sizeof(struct ucred))]; struct msghdr hdr = { Loading @@ -60,6 +59,9 @@ bool LogListener::onDataAvailable(SocketClient *cli) { int socket = cli->getSocket(); // To clear the entire buffer is secure/safe, but this contributes to 1.68% // overhead under logging load. We are safe because we check counts. // memset(buffer, 0, sizeof(buffer)); ssize_t n = recvmsg(socket, &hdr, 0); if (n <= (ssize_t)(sizeof(android_log_header_t))) { return false; Loading