Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a0ee64f authored by Josh Gao's avatar Josh Gao
Browse files

debuggerd_test: improve error when crasher fails to exec. 

Bug: http://b/35100742
Test: rm /system/bin/crasher && /data/nativetest/debugerd_test/debuggerd_test32
Change-Id: I02faec3b7f7ef62bb8a2ac2af730506e3d28e03e
parent a7d7eb6d

debuggerd/debuggerd_test.cpp

+4 −2
Original line number Diff line number Diff line
@@ -192,7 +192,7 @@ void CrasherTest::StartCrasher(const std::string& crash_type) { 
  std::string type = "wait-" + crash_type;

  StartProcess([type]() {

    execl(CRASHER_PATH, CRASHER_PATH, type.c_str(), nullptr);

    err(1, "exec failed");

    exit(errno);

  });

}
@@ -216,7 +216,9 @@ void CrasherTest::AssertDeath(int signo) { 
    FAIL() << "failed to wait for crasher: " << strerror(errno);

  }



  if (!WIFSIGNALED(status)) {

  if (WIFEXITED(status)) {

    FAIL() << "crasher failed to exec: " << strerror(WEXITSTATUS(status));

  } else if (!WIFSIGNALED(status)) {

    FAIL() << "crasher didn't terminate via a signal";

  }

  ASSERT_EQ(signo, WTERMSIG(status));