Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7518e8ba authored by Bradley Furman's avatar Bradley Furman
Browse files

Updates the FB_COMMAND_SIZE from 64 to the linux max value of 4096 and 

updates the relevant unit tests.

BUG=182864081

Test: Update the size check to the existing unit tests

Change-Id: I66b08884a5228e164c22c575a6f6c82a236fece2
parent 39fee4c4

fastboot/constants.h

+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ 
#define RESPONSE_DATA "DATA"

#define RESPONSE_INFO "INFO"



#define FB_COMMAND_SZ 64

#define FB_COMMAND_SZ 4096

#define FB_RESPONSE_SZ 256



#define FB_VAR_VERSION "version"

fastboot/fuzzy_fastboot/main.cpp

+4 −4
Original line number Diff line number Diff line
@@ -901,19 +901,19 @@ TEST_F(Fuzz, BadCommandTooLarge) { 
            << "Device did not respond with failure after sending length " << s.size()

            << " string of random ASCII chars";

    if (ret == IO_ERROR) EXPECT_EQ(transport->Reset(), 0) << "USB reset failed";

    std::string s1 = RandomString(1000, rand_legal);

    std::string s1 = RandomString(10000, rand_legal);

    ret = fb->RawCommand(s1);

    EXPECT_TRUE(ret == DEVICE_FAIL || ret == IO_ERROR)

            << "Device did not respond with failure after sending length " << s1.size()

            << " string of random ASCII chars";

    if (ret == IO_ERROR) EXPECT_EQ(transport->Reset(), 0) << "USB reset failed";

    std::string s2 = RandomString(1000, rand_illegal);

    std::string s2 = RandomString(10000, rand_illegal);

    ret = fb->RawCommand(s2);

    EXPECT_TRUE(ret == DEVICE_FAIL || ret == IO_ERROR)

            << "Device did not respond with failure after sending length " << s2.size()

            << " string of random non-ASCII chars";

    if (ret == IO_ERROR) EXPECT_EQ(transport->Reset(), 0) << "USB reset failed";

    std::string s3 = RandomString(1000, rand_char);

    std::string s3 = RandomString(10000, rand_char);

    ret = fb->RawCommand(s3);

    EXPECT_TRUE(ret == DEVICE_FAIL || ret == IO_ERROR)

            << "Device did not respond with failure after sending length " << s3.size()
@@ -935,7 +935,7 @@ TEST_F(Fuzz, BadCommandTooLarge) { 


TEST_F(Fuzz, CommandTooLarge) {

    for (const std::string& s : CMDS) {

        std::string rs = RandomString(1000, rand_char);

        std::string rs = RandomString(10000, rand_char);

        RetCode ret;

        ret = fb->RawCommand(s + rs);

        EXPECT_TRUE(ret == DEVICE_FAIL || ret == IO_ERROR)