Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71867873 authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

fs_mgr: correct error handling 

Fix a few areas that mismanage error return values, and can result in
confusing messaging from the adb commands.

Test: manual
Bug: 109821005
Change-Id: Ib00069c9605df453ac8f600c7906649deebfd626
parent 5f6b0697

fs_mgr/fs_mgr_overlayfs.cpp

+3 −1
Original line number Diff line number Diff line
@@ -163,7 +163,9 @@ bool fs_mgr_wants_overlayfs() { 
    // Overlayfs available in the kernel, and patched for override_creds?

    static signed char overlayfs_in_kernel = -1;  // cache for constant condition

    if (overlayfs_in_kernel == -1) {

        auto save_errno = errno;

        overlayfs_in_kernel = !access("/sys/module/overlay/parameters/override_creds", F_OK);

        errno = save_errno;

    }

    return overlayfs_in_kernel;

}
@@ -429,7 +431,7 @@ bool fs_mgr_overlayfs_teardown(const char* mount_point, bool* change) { 
    const auto newpath = oldpath + ".teardown";

    ret &= fs_mgr_rm_all(newpath);

    auto save_errno = errno;

    if (rename(oldpath.c_str(), newpath.c_str())) {

    if (!rename(oldpath.c_str(), newpath.c_str())) {

        if (change) *change = true;

    } else if (errno != ENOENT) {

        ret = false;