Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d981af1 authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

logd: report statistics memory overhead 

Add in to the Total Overhead the amount of storage we are
using to hold on to the statistics.

Test: see that the Total Overhead accounts for about 100K
Bug: 31942525
Change-Id: Ibe241c0bccc5a9df52395802338c8a7fc3b64104
parent fc3e9068

logd/LogStatistics.cpp

+1 −0
Original line number Diff line number Diff line
@@ -547,6 +547,7 @@ std::string LogStatistics::format(uid_t uid, pid_t pid, 
        }

        spaces += spaces_total;

    }

    totalSize += sizeOf();

    if (spaces < 0) spaces = 0;

    output += android::base::StringPrintf("%*s%zu", spaces, "", totalSize);

logd/LogStatistics.h

+42 −0
Original line number Diff line number Diff line
@@ -42,8 +42,30 @@ class LogHashtable { 


    std::unordered_map<TKey, TEntry> map;



    size_t bucket_size() const {

        size_t count = 0;

        for (size_t idx = 0; idx < map.bucket_count(); ++idx) {

            size_t bucket_size = map.bucket_size(idx);

            if (bucket_size == 0) bucket_size = 1;

            count += bucket_size;

        }

        float load_factor = map.max_load_factor();

        if (load_factor < 1.0) return count;

        return count * load_factor;

    }



    static const size_t unordered_map_per_entry_overhead = sizeof(void*);

    static const size_t unordered_map_bucket_overhead = sizeof(void*);



public:



    // Estimate unordered_map memory usage.

    size_t sizeOf() const {

        return sizeof(*this) +

               (map.size() * (sizeof(TEntry) + unordered_map_per_entry_overhead)) +

               (bucket_size() * sizeof(size_t) + unordered_map_bucket_overhead);

    }



    typedef typename std::unordered_map<TKey, TEntry>::iterator iterator;

    typedef typename std::unordered_map<TKey, TEntry>::const_iterator const_iterator;
@@ -155,6 +177,7 @@ public: 
        }

        return output;

    }



};



namespace EntryBaseConstants {
@@ -472,7 +495,26 @@ class LogStatistics { 
    // security tag list

    tagTable_t securityTagTable;



    size_t sizeOf() const {

        size_t size = sizeof(*this) + pidTable.sizeOf() + tidTable.sizeOf() +

                      tagTable.sizeOf() + securityTagTable.sizeOf();

        for(auto it : pidTable) {

            const char* name = it.second.getName();

            if (name) size += strlen(name) + 1;

        }

        for(auto it : tidTable) {

            const char* name = it.second.getName();

            if (name) size += strlen(name) + 1;

        }

        log_id_for_each(id) {

            size += uidTable[id].sizeOf();

            size += pidSystemTable[id].sizeOf();

        }

        return size;

    }



public:



    LogStatistics();



    void enableStatistics() { enable = true; }