Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66607ebc authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

logd: document ro.logd.size 

Bad comment advise in LogBuffer.cpp results in partners failing to
considering using ro.logd.size to set the platform buffer size
default.

NB: It is not good practice to increase the log buffer size to deal
with logspam, as increases will result in logd scale issues getting
closer to hitting the background cgroup cpu cap. Once we hit that
cap, logd spirals, pruning old entries slower than the incoming log
entries. logd.writer will take 100% cpu.

Change-Id: If4a7a74f300d078eeaed0ffd3eb3fd77d1f9fe90
parent 946d8152

logd/LogBuffer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ 
#include "LogReader.h"



// Default

#define LOG_BUFFER_SIZE (256 * 1024) // Tuned on a per-platform basis here?

#define LOG_BUFFER_SIZE (256 * 1024) // Tuned with ro.logd.size per-platform

#define log_buffer_size(id) mMaxSize[id]

#define LOG_BUFFER_MIN_SIZE (64 * 1024UL)

#define LOG_BUFFER_MAX_SIZE (256 * 1024 * 1024UL)

logd/README.property

+5 −1
Original line number Diff line number Diff line
@@ -15,7 +15,11 @@ persist.logd.logpersistd string Enable logpersist daemon, "logcatd" 
persist.logd.size          number  ro    Global default size of the buffer for

                                         all log ids at initial startup, at

                                         runtime use: logcat -b all -G <value>

ro.logd.size               number svelte default for persist.logd.size

ro.logd.size               number svelte default for persist.logd.size. Larger

                                         platform default sizes than 256KB are

                                         known to not scale well under log spam

                                         pressure. Address the spam first,

                                         resist increasing the log buffer.

persist.logd.size.<buffer> number  ro    Size of the buffer for <buffer> log

ro.logd.size.<buffer>      number svelte default for persist.logd.size.<buffer>

ro.config.low_ram          bool   false  if true, logd.statistics, logd.kernel