Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 653b0638 authored by Jooyung Han's avatar Jooyung Han
Browse files

init: no bootstrap mount namespace for microdroid 

The reason for two mount namespace (bootstrap/default) is that we have
two sets of different APEXes to activate. But in microdroid, we don't
need two separate mount namespaces because there's only one set of
non-updatable APEXes in built-in directories and payloads (passed from
host Android).

Bug: 185991357
Test: MicrodroidHostTestCases
Change-Id: I4469f3b1d90f9543ecb980a450eaaf1c20b94c58
parent 59c744bd

init/mount_namespace.cpp

+16 −1
Original line number Diff line number Diff line
@@ -82,6 +82,21 @@ static bool IsApexUpdatable() { 
    return updatable;

}



static bool IsMicrodroid() {

    static bool is_microdroid = android::base::GetProperty("ro.hardware", "") == "microdroid";

    return is_microdroid;

}



// In case we have two sets of APEXes (non-updatable, updatable), we need two separate mount

// namespaces.

static bool NeedsTwoMountNamespaces() {

    if (!IsApexUpdatable()) return false;

    if (IsRecoveryMode()) return false;

    // In microdroid, there's only one set of APEXes in built-in directories include block devices.

    if (IsMicrodroid()) return false;

    return true;

}



#ifdef ACTIVATE_FLATTENED_APEX



static Result<void> MountDir(const std::string& path, const std::string& mount_path) {
@@ -260,7 +275,7 @@ bool SetupMountNamespaces() { 
    // number of essential APEXes (e.g. com.android.runtime) are activated.

    // In the namespace for post-apexd processes, all APEXes are activated.

    bool success = true;

    if (IsApexUpdatable() && !IsRecoveryMode()) {

    if (NeedsTwoMountNamespaces()) {

        // Creating a new namespace by cloning, saving, and switching back to

        // the original namespace.

        if (unshare(CLONE_NEWNS) == -1) {