Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 611c6f7d authored by Yifan Hong's avatar Yifan Hong
Browse files

Revert "libsnapshot callstack files readable by dumpstate" 

This reverts commit faa49d1d.

Reason for revert: Callstack should not be logged.

Test: none
Bug: 148818798

Change-Id: Ie5506ae0c7408e255a464b2f403d0a47d272229e
parent ffd1f52c

fs_mgr/libsnapshot/snapshot.cpp

+1 −6
Original line number Diff line number Diff line
@@ -239,12 +239,7 @@ bool SnapshotManager::RemoveAllUpdateState(LockedFile* lock, const std::function 
    LOG(WARNING) << callstack_str.c_str();

    std::stringstream path;

    path << "/data/misc/snapshotctl_log/libsnapshot." << Now() << ".log";

    std::string path_str = path.str();

    android::base::WriteStringToFile(callstack_str.c_str(), path_str);

    if (chmod(path_str.c_str(), 0644) == -1) {

        PLOG(WARNING) << "Unable to chmod 0644 "

                      << ", file maybe dropped from bugreport:" << path_str;

    }

    android::base::WriteStringToFile(callstack_str.c_str(), path.str());

#endif



    if (!RemoveAllSnapshots(lock)) {