Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e8d68c2 authored by Josh Gao's avatar Josh Gao
Browse files

debuggerd_handler: demote abort on exec failure to log.

If a process is ptraced already, we might not be able to exec crash_dump
due to selinux. Since we can be called for non-fatal events, we
shouldn't abort in that case.

Bug: http://b/128054996
Test: treehugger
Change-Id: I1442041caa7af908df2ab87b9e010c44082e7587
parent eecd5cc5
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -383,7 +383,9 @@ static int debuggerd_dispatch_pseudothread(void* arg) {

    execle(CRASH_DUMP_PATH, CRASH_DUMP_NAME, main_tid, pseudothread_tid, debuggerd_dump_type,
           nullptr, nullptr);
    fatal_errno("exec failed");
    async_safe_format_log(ANDROID_LOG_FATAL, "libc", "failed to exec crash_dump helper: %s",
                          strerror(errno));
    return 1;
  }

  input_write.reset();