Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ba30034 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

liblog: use SOCK_NONBLOCK directly. 

No need to have a race, even if it doesn't matter.

Change-Id: Ia79f2633643bc63618de0fd85953b3226415484f
parent e5b7ad1c

liblog/logd_writer.c

+1 −4
Original line number Diff line number Diff line
@@ -67,12 +67,9 @@ static int logdOpen() 
    int i, ret = 0;



    if (logdLoggerWrite.context.sock < 0) {

        i = TEMP_FAILURE_RETRY(socket(PF_UNIX, SOCK_DGRAM | SOCK_CLOEXEC, 0));

        i = TEMP_FAILURE_RETRY(socket(PF_UNIX, SOCK_DGRAM | SOCK_CLOEXEC | SOCK_NONBLOCK, 0));

        if (i < 0) {

            ret = -errno;

        } else if (TEMP_FAILURE_RETRY(fcntl(i, F_SETFL, O_NONBLOCK)) < 0) {

            ret = -errno;

            close(i);

        } else {

            struct sockaddr_un un;

            memset(&un, 0, sizeof(struct sockaddr_un));