Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56675144 authored by Tom Cherry's avatar Tom Cherry
Browse files

fastboot: remove 'powerdown' 

This isn't sent by the fastboot client.
This isn't in our bootloader requirement document.
Neither my hikey nor sailfish respond to this.
The README.md literally uses this as an example for 'unknown command'

Test: fastboot still works.
Change-Id: Ia442a41de517dae078dd7e73c951aadb97646c73
parent 7b02605b

fastboot/README.md

+0 −2
Original line number Diff line number Diff line
@@ -159,8 +159,6 @@ The various currently defined commands are: 
                       the bootloader and then upgrading other partitions

                       using the new bootloader.



    powerdown          Power off the device.







## Client Variables

fastboot/constants.h

+0 −1
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ 
#define FB_CMD_REBOOT_BOOTLOADER "reboot-bootloader"

#define FB_CMD_REBOOT_RECOVERY "reboot-recovery"

#define FB_CMD_REBOOT_FASTBOOT "reboot-fastboot"

#define FB_CMD_POWERDOWN "powerdown"

#define FB_CMD_CREATE_PARTITION "create-logical-partition"

#define FB_CMD_DELETE_PARTITION "delete-logical-partition"

#define FB_CMD_RESIZE_PARTITION "resize-logical-partition"

fastboot/fastboot_driver.cpp

+0 −5
Original line number Diff line number Diff line
@@ -89,10 +89,6 @@ RetCode FastBootDriver::GetVarAll(std::vector<std::string>* response) { 
    return GetVar("all", &tmp, response);

}



RetCode FastBootDriver::Powerdown(std::string* response, std::vector<std::string>* info) {

    return RawCommand(Commands::POWERDOWN, response, info);

}



RetCode FastBootDriver::Reboot(std::string* response, std::vector<std::string>* info) {

    return RawCommand(Commands::REBOOT, response, info);

}
@@ -436,7 +432,6 @@ const std::string FastBootDriver::Commands::DOWNLOAD = "download:"; 
const std::string FastBootDriver::Commands::ERASE = "erase:";

const std::string FastBootDriver::Commands::FLASH = "flash:";

const std::string FastBootDriver::Commands::GET_VAR = "getvar:";

const std::string FastBootDriver::Commands::POWERDOWN = "powerdown";

const std::string FastBootDriver::Commands::REBOOT = "reboot";

const std::string FastBootDriver::Commands::SET_ACTIVE = "set_active:";

const std::string FastBootDriver::Commands::UPLOAD = "upload";

fastboot/fastboot_driver.h

+0 −2
Original line number Diff line number Diff line
@@ -86,7 +86,6 @@ class FastBootDriver { 
    RetCode GetVar(const std::string& key, std::string* val,

                   std::vector<std::string>* info = nullptr);

    RetCode GetVarAll(std::vector<std::string>* response);

    RetCode Powerdown(std::string* response = nullptr, std::vector<std::string>* info = nullptr);

    RetCode Reboot(std::string* response = nullptr, std::vector<std::string>* info = nullptr);

    RetCode RebootTo(std::string target, std::string* response = nullptr,

                     std::vector<std::string>* info = nullptr);
@@ -136,7 +135,6 @@ class FastBootDriver { 
        static const std::string ERASE;

        static const std::string FLASH;

        static const std::string GET_VAR;

        static const std::string POWERDOWN;

        static const std::string REBOOT;

        static const std::string SET_ACTIVE;

        static const std::string UPLOAD;

fastboot/fuzzy_fastboot/main.cpp

+2 −3
Original line number Diff line number Diff line
@@ -86,9 +86,8 @@ std::vector<std::pair<std::string, extension::Configuration::PartitionInfo>> 


const std::string DEFAULT_OUPUT_NAME = "out.img";

// const char scratch_partition[] = "userdata";

const std::vector<std::string> CMDS{"boot",        "continue", "download:", "erase:",

                                    "flash:",      "getvar:",  "powerdown", "reboot",

                                    "set_active:", "upload",   "verify"};

const std::vector<std::string> CMDS{"boot",    "continue", "download:",   "erase:", "flash:",

                                    "getvar:", "reboot",   "set_active:", "upload", "verify"};



// For pretty printing we need all these overloads

::std::ostream& operator<<(::std::ostream& os, const RetCode& ret) {