Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 558f2a16 authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

liblog: test: android_logger_get_ "kernel" log buffer can be empty 

(cherry picked from commit 37eaefa9)

If user build and for the "kernel" log buffer, allow an empty report.

Test: CTS: User: liblog#android_logger_get_
Test: remove ro.debuggable line from /default.prop,
      run liblog-unit-tests --gtest_filter=*.android_logger_get_
Bug: 62030309
Change-Id: I5f91af07608988f322b3c46574becc308e1d8b13
parent 928e606d

liblog/tests/log_read_test.cpp

+7 −3
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
#include <android-base/stringprintf.h>

#include <android/log.h>  // minimal logging API

#include <gtest/gtest.h>

#include <log/log_properties.h>

// Test the APIs in this standalone include file

#include <log/log_read.h>

// Do not use anything in log/log_time.h despite side effects of the above.
@@ -97,8 +98,11 @@ TEST(liblog, android_logger_get_) { 
    /* security buffer is allowed to be denied */

    if (strcmp("security", name)) {

      EXPECT_LT(0, get_log_size);

      /* crash buffer is allowed to be empty, that is actually healthy! */

      EXPECT_LE((strcmp("crash", name)) != 0,

      // crash buffer is allowed to be empty, that is actually healthy!

      // kernel buffer is allowed to be empty on "user" builds

      EXPECT_LE(  // boolean 1 or 0 depending on expected content or empty

          !!((strcmp("crash", name) != 0) &&

             ((strcmp("kernel", name) != 0) || __android_log_is_debuggable())),

          android_logger_get_log_readable_size(logger));

    } else {

      EXPECT_NE(0, get_log_size);