Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d32a486 authored by Nick Kralevich's avatar Nick Kralevich
Browse files

klog: don't unconditionally call mknod() 

If /dev/kmsg already exists, it's unnecessary for klog_init()
to create it's own copy. This avoids needing to grant the mknod
permission to everyone who uses kmsg. Typically the only time
/dev/kmsg doesn't exist is before ueventd starts.

Bug: 21242418
Change-Id: I0c88d80feca6899fcdbc8c9f2f99448ee0a3422d
parent d92fd41f

libcutils/klog.c

+5 −0
Original line number Diff line number Diff line
@@ -40,6 +40,11 @@ void klog_set_level(int level) { 
void klog_init(void) {

    if (klog_fd >= 0) return; /* Already initialized */



    klog_fd = open("/dev/kmsg", O_WRONLY | O_CLOEXEC);

    if (klog_fd >= 0) {

        return;

    }



    static const char* name = "/dev/__kmsg__";

    if (mknod(name, S_IFCHR | 0600, (1 << 8) | 11) == 0) {

        klog_fd = open(name, O_WRONLY | O_CLOEXEC);