Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d1deed1 authored by Yao Chen's avatar Yao Chen
Browse files

Remove a redundant check in statsd socket code. 

The original liblog code has this additional check because there may be multiple writers registered,
there is a for-loop and the retVal is set to be the FIRST error. Statsd doesn't need it because it
 only has one writer.

Test: locally tested.
Change-Id: I03f0015d0c29eba19eb2b5ea145380cb98fb2509
parent 931a840e

libstats/stats_event_list.c

+3 −10
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ static int __write_to_statsd_initialize_locked() { 
}



static int __write_to_stats_daemon(struct iovec* vec, size_t nr) {

    int ret, save_errno;

    int save_errno;

    struct timespec ts;

    size_t len, i;
@@ -145,14 +145,7 @@ static int __write_to_stats_daemon(struct iovec* vec, size_t nr) { 
    save_errno = errno;

    clock_gettime(CLOCK_REALTIME, &ts);



    ret = 0;



    ssize_t retval;

    retval = (*statsdLoggerWrite.write)(&ts, vec, nr);

    if (ret >= 0) {

        ret = retval;

    }



    int ret = (int)(*statsdLoggerWrite.write)(&ts, vec, nr);

    errno = save_errno;

    return ret;

}