Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 46ef7595 authored by Daniel Rosenberg's avatar Daniel Rosenberg
Browse files

libsnapshot: Fix some minor formatting bugs 

A few minor issues snuck through code review.
Removed a debug line in cow_api_test to persist file.
Removed unused function declaration for cow writer
Switched PLOG to LOG where no errno exists.

Change-Id: Ibb774d6de518fc2a8746e4b9eefc3655c9973c30
Bug: 168554689
Test: cow_api_test
parent 0248561a

fs_mgr/libsnapshot/cow_api_test.cpp

+0 −1
Original line number Diff line number Diff line
@@ -272,7 +272,6 @@ TEST_F(CowTest, GetSize) { 
}



TEST_F(CowTest, Append) {

    cow_->DoNotRemove();

    CowOptions options;

    auto writer = std::make_unique<CowWriter>(options);

    ASSERT_TRUE(writer->Initialize(cow_->fd));

fs_mgr/libsnapshot/cow_writer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -247,7 +247,7 @@ bool CowWriter::OpenForAppend(uint64_t label) { 
    }



    if (!found_label) {

        PLOG(ERROR) << "Failed to find last label";

        LOG(ERROR) << "Failed to find last label";

        return false;

    }

fs_mgr/libsnapshot/include/libsnapshot/cow_writer.h

+0 −1
Original line number Diff line number Diff line
@@ -114,7 +114,6 @@ class CowWriter : public ICowWriter { 
    bool OpenForWrite();

    bool OpenForAppend();

    bool OpenForAppend(uint64_t label);

    bool ImportOps(std::unique_ptr<ICowOpIter> iter);

    bool GetDataPos(uint64_t* pos);

    bool WriteRawData(const void* data, size_t size);

    bool WriteOperation(const CowOperation& op, const void* data = nullptr, size_t size = 0);