Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 39a28c25 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

Fix debuggerd's gdbclient instructions. 

We improved gdbclient to make the process simpler, but didn't update
debuggerd to match.

Bug: http://b/22233857
Change-Id: If4137943f567a9e566a3ac7f485c9b1eab2c68e9
parent 913ef1ca

debuggerd/debuggerd.cpp

+6 −20
Original line number Diff line number Diff line
@@ -64,31 +64,17 @@ struct debugger_request_t { 
};



static void wait_for_user_action(const debugger_request_t& request) {

  // Find out the name of the process that crashed.

  char path[64];

  snprintf(path, sizeof(path), "/proc/%d/exe", request.pid);



  char exe[PATH_MAX];

  int count;

  if ((count = readlink(path, exe, sizeof(exe) - 1)) == -1) {

    ALOGE("readlink('%s') failed: %s", path, strerror(errno));

    strlcpy(exe, "unknown", sizeof(exe));

  } else {

    exe[count] = '\0';

  }



  // Explain how to attach the debugger.

  ALOGI("********************************************************\n"

  ALOGI("***********************************************************\n"

        "* Process %d has been suspended while crashing.\n"

        "* To attach gdbserver for a gdb connection on port 5039\n"

        "* and start gdbclient:\n"

        "* To attach gdbserver and start gdb, run this on the host:\n"

        "*\n"

        "*     gdbclient %s :5039 %d\n"

        "*     gdbclient %d\n"

        "*\n"

        "* Wait for gdb to start, then press the VOLUME DOWN key\n"

        "* to let the process continue crashing.\n"

        "********************************************************",

        request.pid, exe, request.tid);

        "***********************************************************",

        request.pid, request.tid);



  // Wait for VOLUME DOWN.

  if (init_getevent() == 0) {