Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 371180bb authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "debuggerd: call setsid in our children."

parents 6e288634 18cb6812

debuggerd/crash_dump.cpp

+6 −0
Original line number Diff line number Diff line
@@ -363,6 +363,12 @@ int main(int argc, char** argv) { 
  DefuseSignalHandlers();

  InstallSigPipeHandler();



  // There appears to be a bug in the kernel where our death causes SIGHUP to

  // be sent to our process group if we exit while it has stopped jobs (e.g.

  // because of wait_for_gdb). Use setsid to create a new process group to

  // avoid hitting this.

  setsid();



  atrace_begin(ATRACE_TAG, "before reparent");

  pid_t target_process = getppid();

debuggerd/handler/debuggerd_handler.cpp

+9 −2
Original line number Diff line number Diff line
@@ -268,8 +268,15 @@ static void create_vm_process() { 
      _exit(errno);

    }



    // Exit immediately on both sides of the fork.

    // crash_dump is ptracing us, so it'll get to do whatever it wants in between.

    // crash_dump is ptracing both sides of the fork; it'll let the parent exit,

    // but keep the orphan stopped to peek at its memory.



    // There appears to be a bug in the kernel where our death causes SIGHUP to

    // be sent to our process group if we exit while it has stopped jobs (e.g.

    // because of wait_for_gdb). Use setsid to create a new process group to

    // avoid hitting this.

    setsid();



    _exit(0);

  }