Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ae8b4c2 authored by Andres Morales's avatar Andres Morales
Browse files

Use proper NO_ERROR checking KS return value 

It's a bit weird that KS defines NO_ERROR outside a
namespace like the Android binder lib, but assigns
it the value 1 instead of 0.

Change-Id: I5aedfd495f2f3bdff7eb1b4ba0f75d335dfe12d9
parent c828ae87

gatekeeperd/gatekeeperd.cpp

+4 −2
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
#include <utils/String16.h>



#include <keystore/IKeystoreService.h>

#include <keystore/keystore.h> // For error code

#include <hardware/gatekeeper.h>



namespace android {
@@ -106,8 +107,9 @@ public: 
            sp<IBinder> binder = sm->getService(String16("android.security.keystore"));

            sp<IKeystoreService> service = interface_cast<IKeystoreService>(binder);

            if (service != NULL) {

                if (service->addAuthToken(*auth_token, *auth_token_length) != NO_ERROR) {

                    ALOGE("Falure sending auth token to KeyStore");

                status_t ret = service->addAuthToken(*auth_token, *auth_token_length);

                if (ret != ResponseCode::NO_ERROR) {

                    ALOGE("Falure sending auth token to KeyStore: %d", ret);

                }

            } else {

                ALOGE("Unable to communicate with KeyStore");