Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29393d69 authored by Nick Kralevich's avatar Nick Kralevich
Browse files

fix another misuse of strncat 

This has the potential to overflow "buffer" if the command line
is more than 4K.

Change-Id: Icdfed0d9d21804f290b75787ef3809e0475b14f0
parent 960ac434

toolbox/log.c

+2 −2
Original line number Diff line number Diff line
@@ -130,8 +130,8 @@ int log_main(int argc, char *argv[]) 
    buffer[0] = '\0';

    

    for (i = optind ; i < argc ; i++) {

        strncat(buffer, argv[i], sizeof(buffer)-1);

        strncat(buffer, " ", sizeof(buffer)-1);

        strlcat(buffer, argv[i], sizeof(buffer)-1);

        strlcat(buffer, " ", sizeof(buffer)-1);

    }



    if(buffer[0] == 0) {