Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2268718e authored by Nick Kralevich's avatar Nick Kralevich
Browse files

check the return value of setuid and friends 

Under some circumstances, setuid() and family can fail,
returning a non-zero value.  (see "man setuid" for details).
If this happens, we want to ensure that init doesn't spawn a
process which has root privileges when it's not suppose to.

Change-Id: Idd03f2c8f82a7eaf6e696b5bcfe308e51ea58b52
parent 609d8828

init/init.c

+12 −3
Original line number Diff line number Diff line
@@ -243,13 +243,22 @@ void service_start(struct service *svc, const char *dynamic_args) 


    /* as requested, set our gid, supplemental gids, and uid */

        if (svc->gid) {

            setgid(svc->gid);

            if (setgid(svc->gid) != 0) {

                ERROR("setgid failed: %s\n", strerror(errno));

                _exit(127);

            }

        }

        if (svc->nr_supp_gids) {

            setgroups(svc->nr_supp_gids, svc->supp_gids);

            if (setgroups(svc->nr_supp_gids, svc->supp_gids) != 0) {

                ERROR("setgroups failed: %s\n", strerror(errno));

                _exit(127);

            }

        }

        if (svc->uid) {

            setuid(svc->uid);

            if (setuid(svc->uid) != 0) {

                ERROR("setuid failed: %s\n", strerror(errno));

                _exit(127);

            }

        }



        if (!dynamic_args) {