Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20954a8e authored by Bart Van Assche's avatar Bart Van Assche
Browse files

init/epoll_test: Improve this test 



Add a move constructor in the CatchDtor class. Check the .emplace()
result. Simplify the destructor. Initialize handler_invoked. Explain the
purpose of this test.

Bug: 213617178
Change-Id: I4d6f97dbb2705a2f2dd78e449ae8de74e90b102f
Signed-off-by: default avatarBart Van Assche <bvanassche@google.com>
parent 3ea0f312

init/epoll_test.cpp

+8 −9
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ 
#include <unordered_set>



#include <android-base/file.h>

#include <android-base/logging.h>

#include <gtest/gtest.h>



namespace android {
@@ -30,14 +31,10 @@ std::unordered_set<void*> sValidObjects; 


class CatchDtor final {

  public:

    CatchDtor() { sValidObjects.emplace(this); }

    CatchDtor(const CatchDtor&) { sValidObjects.emplace(this); }

    ~CatchDtor() {

        auto iter = sValidObjects.find(this);

        if (iter != sValidObjects.end()) {

            sValidObjects.erase(iter);

        }

    }

    CatchDtor() { CHECK(sValidObjects.emplace(this).second); }

    CatchDtor(const CatchDtor&) { CHECK(sValidObjects.emplace(this).second); }

    CatchDtor(const CatchDtor&&) { CHECK(sValidObjects.emplace(this).second); }

    ~CatchDtor() { CHECK_EQ(sValidObjects.erase(this), size_t{1}); }

};



TEST(epoll, UnregisterHandler) {
@@ -48,11 +45,13 @@ TEST(epoll, UnregisterHandler) { 
    ASSERT_EQ(pipe(fds), 0);



    CatchDtor catch_dtor;

    bool handler_invoked;

    bool handler_invoked = false;

    auto handler = [&, catch_dtor]() -> void {

        auto result = epoll.UnregisterHandler(fds[0]);

        ASSERT_EQ(result.ok(), !handler_invoked);

        handler_invoked = true;

        // The assert statement below verifies that the UnregisterHandler() call

        // above did not destroy the current std::function<> instance.

        ASSERT_NE(sValidObjects.find((void*)&catch_dtor), sValidObjects.end());

    };