Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1fcd5125 authored by Tom Cherry's avatar Tom Cherry Committed by Keun young Park
Browse files

init: dump stack when aborting 

Dump init stacks when aborting either due to LOG(FATAL) or in
userdebug/eng builds due to signals, including signals from
sanitizers.

Doesn't work for static first stage init yet, b/133450393 tracks
that.

Also, ensure that LOG(FATAL) in child processes calls abort() in all
stages of init, not just 2nd stage init.

Bug: 131747478
Test: abort init in various ways and see stacks
Test: hang or crash in backtrace handler and see child reboot
Change-Id: Ib53b5d3e7e814244203f875de016ada9900dfce8
Merged-In: Ib53b5d3e7e814244203f875de016ada9900dfce8
(cherry picked from commit 59656fb3)
parent 9122289a

init/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -68,6 +68,7 @@ cc_defaults { 
        "libpropertyinfoparser",

    ],

    shared_libs: [

        "libbacktrace",

        "libbase",

        "libbinder",

        "libbootloader_message",

init/Android.mk

+4 −0
Original line number Diff line number Diff line
@@ -105,6 +105,10 @@ LOCAL_STATIC_LIBRARIES := \ 
    libcap \

    libgsi \

    libcom.android.sysprop.apex \

    liblzma \

    libdexfile_support \

    libunwindstack \

    libbacktrace \



LOCAL_SANITIZE := signed-integer-overflow

# First stage init is weird: it may start without stdout/stderr, and no /proc.

init/first_stage_init.cpp

+2 −6
Original line number Diff line number Diff line
@@ -33,7 +33,6 @@ 
#include <android-base/chrono_utils.h>

#include <android-base/file.h>

#include <android-base/logging.h>

#include <cutils/android_reboot.h>

#include <private/android_filesystem_config.h>



#include "debug_ramdisk.h"
@@ -168,13 +167,10 @@ int FirstStageMain(int argc, char** argv) { 
                    "mode=0755,uid=0,gid=0"));

#undef CHECKCALL



    SetStdioToDevNull(argv);

    // Now that tmpfs is mounted on /dev and we have /dev/kmsg, we can actually

    // talk to the outside world...

    // We need to set up stdin/stdout/stderr for child processes forked from first

    // stage init as part of the mount process.  This closes /dev/console if the

    // kernel had previously opened it.

    auto reboot_bootloader = [](const char*) { RebootSystem(ANDROID_RB_RESTART2, "bootloader"); };

    InitKernelLogging(argv, reboot_bootloader);

    InitKernelLogging(argv);



    if (!errors.empty()) {

        for (const auto& [error_string, error_errno] : errors) {

init/host_init_stubs.h

+5 −0
Original line number Diff line number Diff line
@@ -44,6 +44,11 @@ extern uint32_t (*property_set)(const std::string& name, const std::string& valu 
uint32_t HandlePropertySet(const std::string& name, const std::string& value,

                           const std::string& source_context, const ucred& cr, std::string* error);



// reboot_utils.h

inline void __attribute__((noreturn)) InitFatalReboot() {

    abort();

}



// selinux.h

int SelinuxGetVendorAndroidVersion();

void SelabelInitialize();

init/init.cpp

+2 −14
Original line number Diff line number Diff line
@@ -38,7 +38,6 @@ 
#include <android-base/properties.h>

#include <android-base/stringprintf.h>

#include <android-base/strings.h>

#include <cutils/android_reboot.h>

#include <fs_avb/fs_avb.h>

#include <fs_mgr_vendor_overlay.h>

#include <keyutils.h>
@@ -601,17 +600,6 @@ void HandleKeychord(const std::vector<int>& keycodes) { 
    }

}



static void InitAborter(const char* abort_message) {

    // When init forks, it continues to use this aborter for LOG(FATAL), but we want children to

    // simply abort instead of trying to reboot the system.

    if (getpid() != 1) {

        android::base::DefaultAborter(abort_message);

        return;

    }



    RebootSystem(ANDROID_RB_RESTART2, "bootloader");

}



static void GlobalSeccomp() {

    import_kernel_cmdline(false, [](const std::string& key, const std::string& value,

                                    bool in_qemu) {
@@ -632,8 +620,8 @@ int SecondStageMain(int argc, char** argv) { 
        InstallRebootSignalHandlers();

    }



    // We need to set up stdin/stdout/stderr again now that we're running in init's context.

    InitKernelLogging(argv, InitAborter);

    SetStdioToDevNull(argv);

    InitKernelLogging(argv);

    LOG(INFO) << "init second stage started!";



    // Set init and its forked children's oom_adj.