Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f992186 authored by Paul Lawrence's avatar Paul Lawrence
Browse files

Don't start defaultcrypto twice 

The old way (using triggers) starts defaultcrypto twice because
queue_property_triggers_action retriggers the action.

Bug: 27452459
Change-Id: I48c844836f551673d0dbfed6c33bd8ee1e035f40
parent 3c535de7

init/builtins.cpp

+2 −2
Original line number Diff line number Diff line
@@ -537,11 +537,11 @@ static int do_mount_all(const std::vector<std::string>& args) { 
    import_late(args, 2);



    if (ret == FS_MGR_MNTALL_DEV_NEEDS_ENCRYPTION) {

        property_set("vold.decrypt", "trigger_encryption");

        ActionManager::GetInstance().QueueEventTrigger("encrypt");

    } else if (ret == FS_MGR_MNTALL_DEV_MIGHT_BE_ENCRYPTED) {

        property_set("ro.crypto.state", "encrypted");

        property_set("ro.crypto.type", "block");

        property_set("vold.decrypt", "trigger_default_encryption");

        ActionManager::GetInstance().QueueEventTrigger("defaultcrypto");

    } else if (ret == FS_MGR_MNTALL_DEV_NOT_ENCRYPTED) {

        property_set("ro.crypto.state", "unencrypted");

        ActionManager::GetInstance().QueueEventTrigger("nonencrypted");

rootdir/init.rc

+0 −7
Original line number Diff line number Diff line
@@ -556,13 +556,6 @@ on nonencrypted 
    class_start main

    class_start late_start



on property:vold.decrypt=trigger_default_encryption

    start defaultcrypto



on property:vold.decrypt=trigger_encryption

    start surfaceflinger

    start encrypt



on property:sys.init_log_level=*

    loglevel ${sys.init_log_level}