Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ee75700 authored by Ashok Bhat's avatar Ashok Bhat
Browse files

AArch64: Use negative values in error enumeration 



With AArch64 the enumerations with values in the range
0x80000000 to 0x80000007 are being assigned to ssize_t
typed variables which are 64-bit rather than 32-bit, and
are being used in conditions where they are being checked
for being negative. This is not the case when ssize_t is
64-bit, so redefine this to INT32_MIN value.

Change-Id: I7a031a940a28658b3bf34bebac93dfb3ba397b05
Signed-off-by: default avatarMarcus Oakland <marcus.oakland@arm.com>
Signed-off-by: default avatarAshok Bhat <ashok.bhat@arm.com>
parent 91237300

include/utils/Errors.h

+10 −10
Original line number Diff line number Diff line
@@ -46,18 +46,18 @@ enum { 
    OK                = 0,    // Everything's swell.

    NO_ERROR          = 0,    // No errors.



    UNKNOWN_ERROR       = 0x80000000,

    UNKNOWN_ERROR       = (-2147483647-1), // INT32_MIN value



    NO_MEMORY           = -ENOMEM,

    INVALID_OPERATION   = -ENOSYS,

    BAD_VALUE           = -EINVAL,

    BAD_TYPE            = 0x80000001,

    BAD_TYPE            = (UNKNOWN_ERROR + 1),

    NAME_NOT_FOUND      = -ENOENT,

    PERMISSION_DENIED   = -EPERM,

    NO_INIT             = -ENODEV,

    ALREADY_EXISTS      = -EEXIST,

    DEAD_OBJECT         = -EPIPE,

    FAILED_TRANSACTION  = 0x80000002,

    FAILED_TRANSACTION  = (UNKNOWN_ERROR + 2),

    JPARKS_BROKE_IT     = -EPIPE,

#if !defined(HAVE_MS_C_RUNTIME)

    BAD_INDEX           = -EOVERFLOW,
@@ -67,12 +67,12 @@ enum { 
    UNKNOWN_TRANSACTION = -EBADMSG,

#else    

    BAD_INDEX           = -E2BIG,

    NOT_ENOUGH_DATA     = 0x80000003,

    WOULD_BLOCK         = 0x80000004,

    TIMED_OUT           = 0x80000005,

    UNKNOWN_TRANSACTION = 0x80000006,

    NOT_ENOUGH_DATA     = (UNKNOWN_ERROR + 3),

    WOULD_BLOCK         = (UNKNOWN_ERROR + 4),

    TIMED_OUT           = (UNKNOWN_ERROR + 5),

    UNKNOWN_TRANSACTION = (UNKNOWN_ERROR + 6),

#endif    

    FDS_NOT_ALLOWED     = 0x80000007,

    FDS_NOT_ALLOWED     = (UNKNOWN_ERROR + 7),

};



// Restore define; enumeration is in "android" namespace, so the value defined