Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1bc572df authored by Todd Poynor's avatar Todd Poynor
Browse files

Revert "healthd: don't report fake data for battery-less devices" 

This reverts commit de610c9a.

Reason for revert: May trigger flakiness in CTS ActivityManagerAssistantStackTests.

Change-Id: I02f831048f7802d91331e67bd9006860e4572b92
parent de610c9a

healthd/BatteryMonitor.cpp

+20 −6
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ 
#define POWER_SUPPLY_SYSFS_PATH "/sys/class/" POWER_SUPPLY_SUBSYSTEM

#define FAKE_BATTERY_CAPACITY 42

#define FAKE_BATTERY_TEMPERATURE 424

#define ALWAYS_PLUGGED_CAPACITY 100

#define MILLION 1.0e6

#define DEFAULT_VBUS_VOLTAGE 5000000
@@ -80,11 +81,8 @@ static void initBatteryProperties(BatteryProperties* props) { 
    props->batteryTechnology.clear();

}



BatteryMonitor::BatteryMonitor()

    : mHealthdConfig(nullptr),

      mBatteryDevicePresent(false),

      mBatteryFixedCapacity(0),

      mBatteryFixedTemperature(0) {

BatteryMonitor::BatteryMonitor() : mHealthdConfig(nullptr), mBatteryDevicePresent(false),

    mAlwaysPluggedDevice(false), mBatteryFixedCapacity(0), mBatteryFixedTemperature(0) {

    initBatteryProperties(&props);

}
@@ -225,6 +223,15 @@ bool BatteryMonitor::update(void) { 
        mBatteryFixedTemperature :

        getIntField(mHealthdConfig->batteryTemperaturePath);



    // For devices which do not have battery and are always plugged

    // into power souce.

    if (mAlwaysPluggedDevice) {

        props.chargerAcOnline = true;

        props.batteryPresent = true;

        props.batteryStatus = BATTERY_STATUS_CHARGING;

        props.batteryHealth = BATTERY_HEALTH_GOOD;

    }



    std::string buf;



    if (readFromFile(mHealthdConfig->batteryStatusPath, &buf) > 0)
@@ -398,7 +405,11 @@ status_t BatteryMonitor::getProperty(int id, struct BatteryProperty *val) { 
        break;



    case BATTERY_PROP_BATTERY_STATUS:

        if (mAlwaysPluggedDevice) {

            val->valueInt64 = BATTERY_STATUS_CHARGING;

        } else {

            val->valueInt64 = getChargeStatus();

        }

        ret = NO_ERROR;

        break;
@@ -617,6 +628,9 @@ void BatteryMonitor::init(struct healthd_config *hc) { 
        KLOG_WARNING(LOG_TAG, "No battery devices found\n");

        hc->periodic_chores_interval_fast = -1;

        hc->periodic_chores_interval_slow = -1;

        mBatteryFixedCapacity = ALWAYS_PLUGGED_CAPACITY;

        mBatteryFixedTemperature = FAKE_BATTERY_TEMPERATURE;

        mAlwaysPluggedDevice = true;

    } else {

        if (mHealthdConfig->batteryStatusPath.isEmpty())

            KLOG_WARNING(LOG_TAG, "BatteryStatusPath not found\n");

healthd/include/healthd/BatteryMonitor.h

+1 −0
Original line number Diff line number Diff line
@@ -47,6 +47,7 @@ class BatteryMonitor { 
    struct healthd_config *mHealthdConfig;

    Vector<String8> mChargerNames;

    bool mBatteryDevicePresent;

    bool mAlwaysPluggedDevice;

    int mBatteryFixedCapacity;

    int mBatteryFixedTemperature;

    struct BatteryProperties props;