Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a3c050a authored by Yi-Yo Chiang's avatar Yi-Yo Chiang Committed by Yo Chiang
Browse files

fs_mgr: Refactor ReadDefaultFstab() and ReadFstabFromFile() 

* Eliminate redundant std::move() by transforming
    ReadFstabFromDt(&dt_fstab, false);
    *fstab = std::move(dt_fstab);
  to
    fstab->clear();
    ReadFstabFromDt(fstab, false);

* Don't modify output parameter if ReadFstabFromFile() failed.

Bug: 181110285
Test: Presubmit
Change-Id: I4e4d9852cc618a66d79e423780bf97773dca2a58
parent ea4369d1

fs_mgr/fs_mgr_fstab.cpp

+9 −9
Original line number Original line Diff line number Diff line
@@ -680,7 +680,7 @@ void EnableMandatoryFlags(Fstab* fstab) { 
    }

    }

}

}





bool ReadFstabFromFile(const std::string& path, Fstab* fstab) {

bool ReadFstabFromFile(const std::string& path, Fstab* fstab_out) {

    auto fstab_file = std::unique_ptr<FILE, decltype(&fclose)>{fopen(path.c_str(), "re"), fclose};

    auto fstab_file = std::unique_ptr<FILE, decltype(&fclose)>{fopen(path.c_str(), "re"), fclose};

    if (!fstab_file) {

    if (!fstab_file) {

        PERROR << __FUNCTION__ << "(): cannot open file: '" << path << "'";

        PERROR << __FUNCTION__ << "(): cannot open file: '" << path << "'";
@@ -689,7 +689,8 @@ bool ReadFstabFromFile(const std::string& path, Fstab* fstab) { 




    bool is_proc_mounts = path == "/proc/mounts";

    bool is_proc_mounts = path == "/proc/mounts";





    if (!ReadFstabFile(fstab_file.get(), is_proc_mounts, fstab)) {

    Fstab fstab;

    if (!ReadFstabFile(fstab_file.get(), is_proc_mounts, &fstab)) {

        LERROR << __FUNCTION__ << "(): failed to load fstab from : '" << path << "'";

        LERROR << __FUNCTION__ << "(): failed to load fstab from : '" << path << "'";

        return false;

        return false;

    }

    }
@@ -714,16 +715,17 @@ bool ReadFstabFromFile(const std::string& path, Fstab* fstab) { 
                PERROR << __FUNCTION__ << "(): failed to read DSU LP names";

                PERROR << __FUNCTION__ << "(): failed to read DSU LP names";

                return false;

                return false;

            }

            }

            TransformFstabForDsu(fstab, dsu_slot, Split(lp_names, ","));

            TransformFstabForDsu(&fstab, dsu_slot, Split(lp_names, ","));

        } else if (errno != ENOENT) {

        } else if (errno != ENOENT) {

            PERROR << __FUNCTION__ << "(): failed to access() DSU booted indicator";

            PERROR << __FUNCTION__ << "(): failed to access() DSU booted indicator";

            return false;

            return false;

        }

        }

    }

    }





    SkipMountingPartitions(fstab, false /* verbose */);

    SkipMountingPartitions(&fstab, false /* verbose */);

    EnableMandatoryFlags(fstab);

    EnableMandatoryFlags(&fstab);





    *fstab_out = std::move(fstab);

    return true;

    return true;

}

}
@@ -798,10 +800,8 @@ bool SkipMountingPartitions(Fstab* fstab, bool verbose) { 




// Loads the fstab file and combines with fstab entries passed in from device tree.

// Loads the fstab file and combines with fstab entries passed in from device tree.

bool ReadDefaultFstab(Fstab* fstab) {

bool ReadDefaultFstab(Fstab* fstab) {

    Fstab dt_fstab;

    fstab->clear();

    ReadFstabFromDt(&dt_fstab, false /* verbose */);

    ReadFstabFromDt(fstab, false /* verbose */);



    *fstab = std::move(dt_fstab);





    std::string default_fstab_path;

    std::string default_fstab_path;

    // Use different fstab paths for normal boot and recovery boot, respectively

    // Use different fstab paths for normal boot and recovery boot, respectively