Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1635afe8 authored Jul 15, 2016 by Jeff Sharkey

Only restorecon CE storage after unlocked.

On FBE devices, the filenames inside credential-encrypted directories
are mangled until the key is installed.  This means the initial
restorecon at boot needs to skip these directories until the keys
are installed.

This CL changes the implementation of the "restorecon_recursive"
built-in command to use the new SKIPCE flag to avoid labeling files
in CE directories.  vold will request a restorecon when the keys
are actually installed.

Bug: 30126557
Change-Id: I320584574a4d712c493b5bbd8a79b56c0c04aa58

parent 98933455

init/builtins.cpp

+5 −1

Original line number	Diff line number	Diff line
		@@ -875,9 +875,13 @@ static int do_restorecon_recursive(const std::vector<std::string>& args) {
		int ret = 0;

		for (auto it = std::next(args.begin()); it != args.end(); ++it) {
		if (restorecon_recursive(it->c_str()) < 0)
		/* The contents of CE paths are encrypted on FBE devices until user
		* credentials are presented (filenames inside are mangled), so we need
		* to delay restorecon of those until vold explicitly requests it. */
		if (restorecon_recursive_skipce(it->c_str()) < 0) {
		ret = -errno;
		}
		}
		return ret;
		}

init/util.cpp

+6 −0

Original line number	Diff line number	Diff line
		@@ -471,6 +471,12 @@ int restorecon_recursive(const char* pathname)
		return selinux_android_restorecon(pathname, SELINUX_ANDROID_RESTORECON_RECURSE);
		}

		int restorecon_recursive_skipce(const char* pathname)
		{
		return selinux_android_restorecon(pathname,
		SELINUX_ANDROID_RESTORECON_RECURSE \| SELINUX_ANDROID_RESTORECON_SKIPCE);
		}

		/*
		* Writes hex_len hex characters (1/2 byte) to hex from bytes.
		*/

init/util.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -63,6 +63,7 @@ void import_kernel_cmdline(bool in_qemu,
		int make_dir(const char *path, mode_t mode);
		int restorecon(const char *pathname);
		int restorecon_recursive(const char *pathname);
		int restorecon_recursive_skipce(const char *pathname);
		std::string bytes_to_hex(const uint8_t *bytes, size_t bytes_len);
		bool is_dir(const char* pathname);
		bool expand_props(const std::string& src, std::string* dst);