Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 128826ca authored by Steven Moreland's avatar Steven Moreland
Browse files

libutils: sharedbuffer test - expect greatness! 

This test previously expected failure - a machine which does not have
2GiB of memory. However, while today is becoming the past,
2GiB allocations working is no longer a dream of the future!

Fixes: 186569165
Test: libutils_test
Change-Id: I6a9ed608c0989d415b4e7735b8a451b8928b4083
parent 3b0ec907

libutils/SharedBuffer_test.cpp

+25 −4
Original line number Original line Diff line number Diff line
@@ -32,10 +32,25 @@ TEST(SharedBufferTest, alloc_death) { 
    EXPECT_DEATH(android::SharedBuffer::alloc(SIZE_MAX - sizeof(android::SharedBuffer)), "");

    EXPECT_DEATH(android::SharedBuffer::alloc(SIZE_MAX - sizeof(android::SharedBuffer)), "");

}

}





TEST(SharedBufferTest, alloc_null) {

TEST(SharedBufferTest, alloc_max) {

    // Big enough to fail, not big enough to abort.

    SKIP_WITH_HWASAN;  // hwasan has a 2GiB allocation limit.



    android::SharedBuffer* buf =

            android::SharedBuffer::alloc(SIZE_MAX - sizeof(android::SharedBuffer) - 1);

    if (buf != nullptr) {

        EXPECT_NE(nullptr, buf->data());

        buf->release();

    }

}



TEST(SharedBufferTest, alloc_big) {

    SKIP_WITH_HWASAN;  // hwasan has a 2GiB allocation limit.

    SKIP_WITH_HWASAN;  // hwasan has a 2GiB allocation limit.

    ASSERT_EQ(nullptr, android::SharedBuffer::alloc(SIZE_MAX / 2));



    android::SharedBuffer* buf = android::SharedBuffer::alloc(SIZE_MAX / 2);

    if (buf != nullptr) {

        EXPECT_NE(nullptr, buf->data());

        buf->release();

    }

}

}





TEST(SharedBufferTest, alloc_zero_size) {

TEST(SharedBufferTest, alloc_zero_size) {
@@ -56,7 +71,13 @@ TEST(SharedBufferTest, editResize_null) { 
    // Big enough to fail, not big enough to abort.

    // Big enough to fail, not big enough to abort.

    SKIP_WITH_HWASAN;  // hwasan has a 2GiB allocation limit.

    SKIP_WITH_HWASAN;  // hwasan has a 2GiB allocation limit.

    android::SharedBuffer* buf = android::SharedBuffer::alloc(10);

    android::SharedBuffer* buf = android::SharedBuffer::alloc(10);

    ASSERT_EQ(nullptr, buf->editResize(SIZE_MAX / 2));

    android::SharedBuffer* buf2 = buf->editResize(SIZE_MAX / 2);

    if (buf2 == nullptr) {

        buf->release();

    } else {

        EXPECT_NE(nullptr, buf2->data());

        buf2->release();

    }

}

}





TEST(SharedBufferTest, editResize_zero_size) {

TEST(SharedBufferTest, editResize_zero_size) {