Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0725099e authored by Akilesh Kailash's avatar Akilesh Kailash Committed by Automerger Merge Worker
Browse files

Merge "libsnapshot: Error handling after QuerySnapshotStatus" am: 6f967229 

Original change: https://android-review.googlesource.com/c/platform/system/core/+/1824992

Change-Id: I15cad82611d8ff880ae84c8d5d57a118b95dcc49
parents 2efb060e 6f967229

fs_mgr/libsnapshot/snapshot.cpp

+11 −0
Original line number Diff line number Diff line
@@ -518,6 +518,13 @@ bool SnapshotManager::MapSnapshot(LockedFile* lock, const std::string& name, 
            break;

    }



    if (mode == SnapshotStorageMode::Persistent && status.state() == SnapshotState::MERGING) {

        LOG(ERROR) << "Snapshot: " << name

                   << " has snapshot status Merging but mode set to Persistent."

                   << " Changing mode to Snapshot-Merge.";

        mode = SnapshotStorageMode::Merge;

    }



    DmTable table;

    table.Emplace<DmTargetSnapshot>(0, snapshot_sectors, base_device, cow_device, mode,

                                    kSnapshotChunkSize);
@@ -886,6 +893,10 @@ bool SnapshotManager::QuerySnapshotStatus(const std::string& dm_name, std::strin 
    if (target_type) {

        *target_type = DeviceMapper::GetTargetType(target.spec);

    }

    if (!status->error.empty()) {

        LOG(ERROR) << "Snapshot: " << dm_name << " returned error code: " << status->error;

        return false;

    }

    return true;

}