Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06053405 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

Use _Fork(). 

POSIX issue 8 has a standard way to avoid pthread_atfork() handlers.

Change-Id: I801c55dc3fb9e14cc03f854992d60872c5468ab5
parent b6fc19c3

debuggerd/handler/debuggerd_handler.cpp

+1 −5
Original line number Diff line number Diff line
@@ -275,10 +275,6 @@ static void raise_caps() { 
  }

}



static pid_t __fork() {

  return clone(nullptr, nullptr, 0, nullptr);

}



// Double-clone, with CLONE_FILES to share the file descriptor table for kcmp validation.

// Returns 0 in the orphaned child, the pid of the orphan in the original process, or -1 on failure.

static void create_vm_process() {
@@ -426,7 +422,7 @@ static int debuggerd_dispatch_pseudothread(void* arg) { 
  }



  // Don't use fork(2) to avoid calling pthread_atfork handlers.

  pid_t crash_dump_pid = __fork();

  pid_t crash_dump_pid = _Fork();

  if (crash_dump_pid == -1) {

    async_safe_format_log(ANDROID_LOG_FATAL, "libc",

                          "failed to fork in debuggerd signal handler: %s", strerror(errno));