release-request-33b11ddd-d658-45bf-bdb2-acceb024fe39-for-git_oc-release-404276... (fb9d41d4) · Commits · e / os / android_packages_services_Telecomm

src/com/android/server/telecom/Call.java

+7 −0

Original line number	Diff line number	Diff line
		@@ -578,6 +578,13 @@ public class Call implements CreateConnectionResponse, EventManager.Loggable {
		}

		public void destroy() {
		// We should not keep these bitmaps around because the Call objects may be held for logging
		// purposes.
		// TODO: Make a container object that only stores the information we care about for Logging.
		if (mCallerInfo != null) {
		mCallerInfo.cachedPhotoIcon = null;
		mCallerInfo.cachedPhoto = null;
		}
		Log.addEvent(this, LogUtils.Events.DESTROYED);
		}

+9 −0

Original line number	Diff line number	Diff line
		@@ -77,6 +77,15 @@ public class ConnectionServiceWrapper extends ServiceBinder {
		logIncoming("handleCreateConnectionComplete %s", callId);
		ConnectionServiceWrapper.this
		.handleCreateConnectionComplete(callId, request, connection);

		if (mServiceInterface != null) {
		logOutgoing("createConnectionComplete %s", callId);
		try {
		mServiceInterface.createConnectionComplete(callId,
		Log.getExternalSession());
		} catch (RemoteException e) {
		}
		}
		}
		} finally {
		Binder.restoreCallingIdentity(token);

+9 −0

Original line number	Diff line number	Diff line
		@@ -116,6 +116,10 @@ public class ConnectionServiceFixture implements TestFixture<IConnectionService>
		return fakeConnection;
		}

		@Override
		public void onCreateConnectionComplete(Connection connection) {
		}

		@Override
		public void onConference(Connection cxn1, Connection cxn2) {
		if (((FakeConnection) cxn1).getIsConferenceCreated()) {
		@@ -239,6 +243,11 @@ public class ConnectionServiceFixture implements TestFixture<IConnectionService>
		id, request, isIncoming, isUnknown, null /Session.Info/);
		}

		@Override
		public void createConnectionComplete(String id, Session.Info info) throws RemoteException {
		mConnectionServiceDelegateAdapter.createConnectionComplete(id, null /Session.Info/);
		}

		@Override
		public void createConnectionFailed(PhoneAccountHandle connectionManagerPhoneAccount,
		String callId, ConnectionRequest request, boolean isIncoming,

+10 −0

Original line number	Diff line number	Diff line
		@@ -712,6 +712,10 @@ public class TelecomSystemTest extends TelecomTestCase {
		// Wait for the callback in ConnectionService#onAdapterAttached to execute.
		waitForHandlerAction(new Handler(Looper.getMainLooper()), TEST_TIMEOUT);

		// Ensure callback to CS on successful creation happened.
		verify(connectionServiceFixture.getTestDouble(), timeout(TEST_TIMEOUT))
		.createConnectionComplete(anyString(), any());

		assertEquals(startingNumCalls + 1, mInCallServiceFixtureX.mCallById.size());
		assertEquals(startingNumCalls + 1, mInCallServiceFixtureY.mCallById.size());

		@@ -759,6 +763,12 @@ public class TelecomSystemTest extends TelecomTestCase {

		// Wait for the handler to start the CallerInfo lookup
		waitForHandlerAction(new Handler(Looper.getMainLooper()), TEST_TIMEOUT);

		// Ensure callback to CS on successful creation happened.
		verify(connectionServiceFixture.getTestDouble(), timeout(TEST_TIMEOUT))
		.createConnectionComplete(anyString(), any());


		// Process the CallerInfo lookup reply
		mCallerInfoAsyncQueryFactoryFixture.mRequests.forEach(
		CallerInfoAsyncQueryFactoryFixture.Request::reply);