Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6288a7a authored by Andrew Lee's avatar Andrew Lee
Browse files

Removed failed outgoing calls.

The user is unable to add a call in this bug, because the call is not
add capable. It fails the isAddCallCapable check because there are
multiple calls; one of which is not the same call and does not have
a parent.

This appears to be because of some interaction with Google Voice (at
least in the specific case I was observing), where the initial call
is disconnected and then the call is rerouted. When this initial call
is disconnected, it was not removed, leading to this (erroneous) two
call state.

Fixing this by explicitly calling remove call for failed outgoing
calls. Formerly, they were only marked as disconnected.

Bug: 17731082
Change-Id: I0d6401cbc593a128483072c5faa189949e73d71e
parent 3e3cde1b
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -198,8 +198,7 @@ public final class CallsManager extends Call.ListenerBase {
    public void onFailedOutgoingCall(Call call, DisconnectCause disconnectCause) {
        Log.v(this, "onFailedOutgoingCall, call: %s", call);

        // TODO: Replace disconnect cause with more specific disconnect causes.
        markCallAsDisconnected(call, disconnectCause);
        markCallAsRemoved(call);
    }

    @Override