Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9886a5b authored by Nate Myren's avatar Nate Myren
Browse files

Add note to telecom startOp that they are only for tracing 

So that future auditors don't see these startOp calls as a potential
security issue.

Test: build
Fixes: 170359347
Change-Id: I85b6e52a172b8a4de082ddfed6bbca26036c9ecb
parent 478568d1

src/com/android/server/telecom/InCallController.java

+2 −0
Original line number Diff line number Diff line
@@ -1507,6 +1507,7 @@ public class InCallController extends CallsManagerListenerBase implements 
            }



            if (shouldStart) {

                // Note, not checking return value, as this op call is merely for tracing use

                mAppOpsManager.startOp(AppOpsManager.OP_PHONE_CALL_CAMERA, myUid(),

                        mContext.getOpPackageName(), false, null, null);

                mSensorPrivacyManager.showSensorUseDialog(SensorPrivacyManager.Sensors.CAMERA);
@@ -2465,6 +2466,7 @@ public class InCallController extends CallsManagerListenerBase implements 
                && !isCarrierPrivilegedUsingMicDuringVoipCall();

        if (wasUsingMicrophone != mIsCallUsingMicrophone) {

            if (mIsCallUsingMicrophone) {

                // Note, not checking return value, as this op call is merely for tracing use

                mAppOpsManager.startOp(AppOpsManager.OP_PHONE_CALL_MICROPHONE, myUid(),

                        mContext.getOpPackageName(), false, null, null);

                mSensorPrivacyManager.showSensorUseDialog(SensorPrivacyManager.Sensors.MICROPHONE);